Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces retry logic and enhanced error handling for agent communication in the
CommsManager
class and integrates these improvements into theconvert_script
function. Key changes include adding retry mechanisms, improving JSON parsing for robustness, and updating logging and error reporting.Enhancements to Communication and Retry Logic:
CommsManager
with configurable parameters such asmax_retries
,initial_delay
, andbackoff_factor
. Added theasync_invoke
method to handle retries and error handling during agent communication. [1] [2]convert_script
to use the newCommsManager
for group chat operations, replacing direct calls tochat
withcomms_manager.group_chat
. This ensures retry logic is applied to all communication. [1] [2] [3]Improved Error Handling:
convert_script
to handle malformed or incomplete JSON responses from agents. Fallback values are used to avoid crashes.convert_script
. Critical errors during communication now create logs in the batch service and send error status updates to the client.Codebase Improvements:
CommsManager
for better debugging and maintainability. [1] [2]asyncio.sleep
calls in bothconvert_script
andprocess_batch_async
as they are no longer needed with the new retry logic. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information