Skip to content

[Draft] refactor: refactored code #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ravikirana-Microsoft
Copy link

This pull request introduces several updates to the frontend application, focusing on dependency management, UI enhancements, and code refactoring. Key changes include updating dependencies in package.json, introducing new components for error handling and batch history, and replacing inline styles with SCSS files for better maintainability and consistency.

Dependency Updates:

  • Added @azure/msal-browser and @azure/msal-react to dependencies and updated @types/node in devDependencies. Removed duplicate entries for @azure/msal-browser and @azure/msal-react. [1] [2]
  • Added sass-embedded to devDependencies for SCSS compilation.

UI Enhancements:

  • Introduced a new right-hand panel (PanelRight) with toggle functionality for viewing batch history, including integration with Redux for state management.
  • Added error display components (ErrorContent, ErrorComponent, and FileError) with accordion-style UI for error logs and detailed file-specific errors. [1] [2] [3]
  • Replaced inline styles with SCSS files for components like Content, Header, ConfirmationDialog, and others to improve styling consistency. [1] [2] [3]

Code Refactoring:

  • Updated file paths for components and pages in App.jsx to use consistent directory structures (e.g., ./pages/landingPage/landingPage).
  • Removed redundant CSS rules for .landing-page and added new styles for .panelRight in App.css.

New SCSS Files:

  • Added SCSS files for various components (confirmationDialogue.scss, errorContent.scss, errorsComponent.scss, fileError.scss, content.scss, Header.scss) to centralize and simplify styling. [1] [2] [3] [4] [5] [6]

These updates collectively improve the application's functionality, maintainability, and user experience.## Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Ravikirana-Microsoft
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@Roopan-Microsoft Roopan-Microsoft changed the title refactor: refactored code [Draft] refactor: refactored code May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant