Skip to content

fix: merge datascience v3 and v2 #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 19, 2025
Merged

fix: merge datascience v3 and v2 #974

merged 14 commits into from
Jun 19, 2025

Conversation

peteryang1
Copy link
Collaborator

@peteryang1 peteryang1 commented Jun 18, 2025

Description

Motivation and Context

How Has This Been Tested?

  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

📚 Documentation preview 📚: https://RDAgent--974.org.readthedocs.build/en/974/

@peteryang1 peteryang1 requested a review from Copilot June 18, 2025 16:59
Copilot

This comment was marked as outdated.

@peteryang1 peteryang1 marked this pull request as ready for review June 19, 2025 04:57
@peteryang1 peteryang1 requested a review from Copilot June 19, 2025 05:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the handling of proposal versions by removing v3-specific code paths and streamlining configuration and prompt instructions.

  • Removed DSProposalV3ExpGen references and related conditionals from data science proposal generation.
  • Updated YAML prompts for experiment submissions and feedback adjustments.
  • Added support for function calling in LLM backends, including new configuration settings and abstract method definitions.

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rdagent/scenarios/data_science/loop.py Removed v3-specific imports and conditional branches to unify version handling.
rdagent/scenarios/data_science/dev/prompts.yaml Updated experiment prompt instructions to clarify submission handling.
rdagent/scenarios/data_science/dev/feedback.py Removed untested v3-specific feedback generation logic.
rdagent/oai/llm_conf.py Introduced a new configuration option for enabling function calling.
rdagent/oai/backend/litellm.py Adjusted response_format handling and added support_function_calling method.
rdagent/oai/backend/deprec.py Added support_function_calling with a FIXME comment indicating pending improvement.
rdagent/oai/backend/base.py Added an abstract support_function_calling method to enforce subclass implementations.
rdagent/components/coder/data_science/pipeline/prompts.yaml Removed v3-specific pipeline prompt sections.
rdagent/components/coder/data_science/pipeline/init.py Eliminated a temporary patch for proposal version v3 in the pipeline coder.
Comments suppressed due to low confidence (2)

rdagent/scenarios/data_science/loop.py:96

  • Ensure that using import_class to handle 'v3' (which is now absent from the valid list) produces the expected behavior and does not inadvertently bypass necessary initialization steps.
            if DS_RD_SETTING.proposal_version not in ["v1", "v2"]:

rdagent/oai/backend/litellm.py:93

  • Review the removal of 'response_format' from kwargs, as this may affect downstream consumers expecting this field; ensure that clients are updated accordingly.
        elif not supports_response_schema(model=LITELLM_SETTINGS.chat_model) and "response_format" in kwargs:

@peteryang1 peteryang1 merged commit 1ba7548 into main Jun 19, 2025
9 checks passed
@peteryang1 peteryang1 deleted the xuyang1/pv3_debug branch June 19, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants