Skip to content

Fixed boolean pval calculation and added tests #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Fixed boolean pval calculation and added tests #19

merged 1 commit into from
May 7, 2025

Conversation

aprilk-ms
Copy link
Collaborator

@aprilk-ms aprilk-ms commented May 7, 2025 •
edited
Loading

This resolves issue #18

  • Updated calculation of p-value for boolean scores
  • Added unit tests to cover other score types

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 01:00
Copilot
Copilot AI reviewed May 7, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@aprilk-ms aprilk-ms merged commit 2a4a91d into main May 7, 2025
9 checks passed
@aprilk-ms aprilk-ms deleted the aprilk/fix-boolean-metrics branch May 9, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@QIU-Shuo QIU-Shuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprilk-ms @QIU-Shuo