Fixing Sample ADO extension Yaml file #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sample ADO YAML file to improve Azure CLI login handling by modifying the existing Azure CLI task and adding a new bash step for service principal login.
- Renamed the displayName for the Azure CLI task.
- Added environment variable setting to store service principal credentials.
- Introduced a new bash step that performs an az login using the provided credentials.
Comments suppressed due to low confidence (2)
samples/ado-multiple-agents.yml:12
- [nitpick] Consider using a consistent display naming convention for similar tasks. The Azure CLI login task uses "Azure CLI login" while the later step uses an abbreviated 'Az Login', which may be confusing for users.
displayName: "Azure CLI login"
samples/ado-multiple-agents.yml:26
- [nitpick] Align the displayName for the az login step with the other Azure CLI task to ensure consistency across the YAML file. Either choose the full form or consistently use the abbreviation throughout.
displayName: 'Az Login'
aprilk-ms
previously approved these changes
May 13, 2025
aprilk-ms
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.