Skip to content

Updating credential #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2025
Merged

Updating credential #29

merged 8 commits into from
May 17, 2025

Conversation

risinh
Copy link
Member

@risinh risinh commented May 17, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 17, 2025 20:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the credential mechanism and API version for AI Agent Evaluation along with a minor version bump.

  • Bump the patch version in task.json from 60 to 61
  • Refactor credential instantiation in action.py
  • Update API version to a preview version in action.py

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tasks/AIAgentEvaluation/task.json Bumped the patch version to reflect updated credentials
action.py Extracted the credential instantiation and updated the API version to a preview version
Comments suppressed due to low confidence (2)

tasks/AIAgentEvaluation/task.json:12

  • Ensure the patch version bump from 60 to 61 aligns with the project's release and versioning strategy, and update any related documentation if needed.
"Patch": 61

action.py:344

  • The instantiation of DefaultAzureCredential now omits the exclude_shared_token_cache_credential parameter; please confirm that this behavior change is intentional.
credential = DefaultAzureCredential()

aprilk-ms
aprilk-ms previously approved these changes May 17, 2025
@risinh risinh merged commit f278ede into main May 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants