Update dataset-tiny.json #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enriches the dataset-tiny.json fixture by adding new evaluators and significantly expanding the set of test queries for product-related prompts.
- Adds five new evaluator types to the
evaluatorsarray - Replaces two existing queries and appends ~38 new product-focused queries
- Keeps the JSON structure intact while broadening test coverage
Comments suppressed due to low confidence (2)
samples/data/dataset-tiny.json:3
- [nitpick] The evaluators list is unsorted, which can make it harder to scan and maintain. Consider alphabetizing the array or grouping evaluators by function.
"evaluators": ["IntentResolutionEvaluator", "FluencyEvaluator", "CoherenceEvaluator", "RelevanceEvaluator", "TaskAdherenceEvaluator", "HateUnfairnessEvaluator", "ViolenceEvaluator"],
samples/data/dataset-tiny.json:2
- [nitpick] With ~40 new entries, the file has grown beyond what 'tiny' suggests; consider renaming the dataset and file to better reflect its expanded scope.
"name": "test-dataset-tiny",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.