Skip to content

Hanch demo evals 1 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

bhcglx
Copy link

@bhcglx bhcglx commented Apr 29, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 20:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request, titled "Hanch demo evals 1," updates the CI workflow configuration for testing local actions.

  • Updated the azure-aiproject-connection-string with new connection details.
  • Modified the agent-ids assignment to use a single agent id regardless of condition, and left a commented-out alternative.

@@ -75,9 +75,10 @@ jobs:
- name: Test local action
uses: ./
with:
azure-aiproject-connection-string: "eastus2.api.azureml.ms;040c3674-68d4-431e-b456-a8542c77b8d1;rg-aprilk-ai-agent-test-01b;ai-project-56uji2dklqysk"
azure-aiproject-connection-string: "eastus2.api.azureml.ms;80d2c6c6-fa64-4ab1-8aa5-4e118c6b16ce;rg-aprilk-test-agent-template-02;hanch-demo-evals"
Copy link
Preview

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider storing the Azure connection string in GitHub secrets instead of hardcoding it in the workflow file to enhance security.

Suggested change
azure-aiproject-connection-string: "eastus2.api.azureml.ms;80d2c6c6-fa64-4ab1-8aa5-4e118c6b16ce;rg-aprilk-test-agent-template-02;hanch-demo-evals"
azure-aiproject-connection-string: ${{ secrets.AZURE_CONNECTION_STRING }}

Copilot uses AI. Check for mistakes.

agent-ids: ${{ github.event.inputs.compare_view == 'true' && 'asst_bkaOZYoShhZny7T57DO4X08z' || 'asst_bkaOZYoShhZny7T57DO4X08z' }}
Copy link
Preview

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional expression for agent-ids is redundant since both outcomes return the same value; consider simplifying this to a single value assignment.

Suggested change
agent-ids: ${{ github.event.inputs.compare_view == 'true' && 'asst_bkaOZYoShhZny7T57DO4X08z' || 'asst_bkaOZYoShhZny7T57DO4X08z' }}
agent-ids: 'asst_bkaOZYoShhZny7T57DO4X08z'

Copilot uses AI. Check for mistakes.

agent-ids: ${{ github.event.inputs.compare_view == 'true' && 'asst_bkaOZYoShhZny7T57DO4X08z' || 'asst_bkaOZYoShhZny7T57DO4X08z' }}
# agent-ids: ${{ github.event.inputs.compare_view == 'true' && 'asst_bkaOZYoShhZny7T57DO4X08z, asst_Rr2NFM6R4XVfasggN9EYWGh7' || 'asst_bkaOZYoShhZny7T57DO4X08z' }}
Copy link
Preview

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] If this commented-out code is no longer necessary, it is best to remove it to keep the workflow file clean.

Suggested change
# agent-ids: ${{ github.event.inputs.compare_view == 'true' && 'asst_bkaOZYoShhZny7T57DO4X08z, asst_Rr2NFM6R4XVfasggN9EYWGh7' || 'asst_bkaOZYoShhZny7T57DO4X08z' }}

Copilot uses AI. Check for mistakes.

@bhcglx bhcglx closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant