Skip to content

Fix defect rate #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Fix defect rate #9

merged 4 commits into from
Apr 30, 2025

Conversation

aprilk-ms
Copy link
Collaborator

  • Updated convert pass/fail to boolean logic to take care of the inverse we need to do for defect rate
  • Added Code Vulnerability evaluator to sample data sets

@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 05:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the defect rate calculation by updating the boolean conversion logic and enhancing the evaluator metadata usage. It changes the tests to pass an evaluator metadata argument, updates the conversion logic in both the analysis and action modules, and adds a new Code Vulnerability evaluator to sample data sets.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
tests/test_validation.py Updated calls to validate_input_data to include the evaluator metadata.
tests/test_analysis.py Updated tests for boolean conversion using metadata-driven logic.
analysis/analysis.py Removed conditional inversion logic for defect rate calculations.
action.py Updated validate_input_data signature and removed deprecated conversion.
Files not reviewed (2)
  • samples/data/dataset-small.json: Language not supported
  • samples/data/dataset.json: Language not supported
Comments suppressed due to low confidence (1)

action.py:490

  • It is best to remove temporary or debugging comments like '# REMOVE ME' before finalizing the merge to maintain code clarity.
    # REMOVE ME

risinh
risinh previously approved these changes Apr 30, 2025
@aprilk-ms aprilk-ms merged commit 7490e91 into main Apr 30, 2025
7 checks passed
@aprilk-ms aprilk-ms deleted the aprilk/fix-defect-rate branch May 9, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants