fix(react-accordion): adjust accordion header chevron alignment styles #34616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
changed the title
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -138,3 +138,29 @@ Disabled.storyName = 'disabled'; | |||
|
|
|||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Accordion Converged 18 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Accordion Converged.expandIconPosition end - RTL.normal.chromium.png | 624 | Changed |
| vr-tests-react-components/Accordion Converged.disabled - Dark Mode.normal.chromium.png | 645 | Changed |
| vr-tests-react-components/Accordion Converged.expandIcon Icon- - Dark Mode.normal.chromium.png | 2632 | Changed |
| vr-tests-react-components/Accordion Converged.expandIconPosition end .normal.chromium.png | 625 | Changed |
| vr-tests-react-components/Accordion Converged.icon Icon- - RTL.normal.chromium.png | 1437 | Changed |
| vr-tests-react-components/Accordion Converged.disabled - High Contrast.normal.chromium.png | 2382 | Changed |
| vr-tests-react-components/Accordion Converged.expandIcon Icon- - High Contrast.normal.chromium.png | 3145 | Changed |
| vr-tests-react-components/Accordion Converged.expandIcon Icon- - RTL.normal.chromium.png | 2244 | Changed |
| vr-tests-react-components/Accordion Converged.icon Icon- .normal.chromium.png | 1436 | Changed |
| vr-tests-react-components/Accordion Converged.disabled.normal.chromium.png | 932 | Changed |
| vr-tests-react-components/Accordion Converged.expandIcon Icon- .normal.chromium.png | 2243 | Changed |
| vr-tests-react-components/Accordion Converged.size - RTL.normal.chromium.png | 1460 | Changed |
| vr-tests-react-components/Accordion Converged.visibility+focus - Dark Mode.focus opened.chromium.png | 744 | Changed |
| vr-tests-react-components/Accordion Converged.visibility+focus - High Contrast.focus closed.chromium.png | 890 | Changed |
| vr-tests-react-components/Accordion Converged.size.normal.chromium.png | 1460 | Changed |
| vr-tests-react-components/Accordion Converged.visibility+focus.focus opened.chromium.png | 626 | Changed |
| vr-tests-react-components/Accordion Converged.visibility+focus - RTL.focus opened.chromium.png | 626 | Changed |
| vr-tests-react-components/Accordion Converged.Multiline Heading.normal.chromium.png | 0 | Added |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 275 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 953 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.chromium.png | 678 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
There were 10 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The icon is vertically centered in the header, instead of being aligned with the first line of text.
New Behavior
The icon is aligned vertically with the first line of text in the header
Related Issue(s)