update dialog to use semantic tokens #34624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachethecreator
commented
Jun 10, 2025
Comment on lines
16
to
17
| padding: tokens.strokeWidthThick, | ||
| margin: `calc(${tokens.strokeWidthThick} * -1)`, |
There was a problem hiding this comment.
First gap noted in Loop doc
See designs here (no padding for content slot)
rachethecreator
commented
Jun 10, 2025
| @@ -12,9 +13,10 @@ export const dialogBodyClassNames: SlotClassNames<DialogBodySlots> = { | |||
| */ | |||
| const useResetStyles = makeResetStyles({ | |||
| overflow: 'unset', | |||
| gap: DIALOG_GAP, | |||
| rowGap: semanticTokens._ctrlDialogGapBetweenContentMedium, | |||
There was a problem hiding this comment.
Second gap noted in Loop doc
See designs here (24px gap between the header, content, and footer rows within Dialog body)
|
Pull request demo site: URL |
packages/react-components/react-dialog/library/src/contexts/constants.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-dialog/library/src/contexts/index.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
requested changes
Jun 11, 2025
rachethecreator
force-pushed
the
ryoo/dialog-semantic-tokens
branch
from
27c0d1a to
322668c
Compare
Mitch-At-Work
approved these changes
Jun 16, 2025
rachethecreator
force-pushed
the
ryoo/dialog-semantic-tokens
branch
from
070792f to
24bc454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to semantic tokens where applicable for react-dialog
Add fallback values to fluentOverrides
Gaps noted here
Kumo implementation here
Previous Behavior
Used fluentui/tokens
New Behavior
Uses fluentui/semantic-tokens if a replacement exists