Skip to content

Extended Tokens: React-Spinner #34645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: extended-tokens
Choose a base branch
from
Open

Extended Tokens: React-Spinner #34645

wants to merge 5 commits into from
+216 −53

Conversation

Mitch-At-Work
Copy link
Contributor

Upgrade React-spinner to semantic tokens.

Gaps:

  • No inverted tokens in semantic
  • Spinner in fluent has multiple sizes, we do not have token variants for these options
  • Spinner in fluent uses multiple text sizes, defaults to general text tokens for now

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review June 12, 2025 18:11
@Mitch-At-Work Mitch-At-Work requested review from a team as code owners June 12, 2025 18:11
@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@Hotell Hotell requested review from dmytrokirpa and mainframev June 18, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachethecreator rachethecreator rachethecreator approved these changes

@marcosmoura marcosmoura Awaiting requested review from marcosmoura

@etudie etudie Awaiting requested review from etudie

@dmytrokirpa dmytrokirpa Awaiting requested review from dmytrokirpa

@mainframev mainframev Awaiting requested review from mainframev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mitch-At-Work @rachethecreator