update message bar to use semantic tokens #34657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
| borderRadius: tokens.borderRadiusMedium, | ||
| paddingLeft: semanticTokens._ctrlMessageBarPaddingContentAlignDefault, | ||
| paddingRight: semanticTokens.paddingContentAlignOutdentIconOnSubtle, | ||
| paddingTop: semanticTokens._ctrlMessageBarPaddingY, |
There was a problem hiding this comment.
Let's rename this _ctrlMessageBarPaddingVertical to stick with current naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to semantic tokens where applicable for react-message-bar
Add fallback values to fluentOverrides
Gaps noted here
Kumo implementation here
Figma design here
Previous Behavior
Used fluentui/tokens
New Behavior
Used fluentui/semantic-tokens if a replacement exists