feat: improve useSafeZoneArea() hook #34677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
layershifter
force-pushed
the
fix/improve-safe-zone
branch
from
d3312cd to
bd61426
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full - RTL.chromium.png | 1157 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 829 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 717 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
layershifter
force-pushed
the
fix/improve-safe-zone
branch
from
bd61426 to
03f4238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
usePositioning()hook is re-exported from@fluentui/react-componentsuseSafeZoneArea()hook is re-export from@fluentui/react-componentsuseSafeZoneArea()was heavily re-implemented internally based on the latest findings in the integration processuseSafeZoneArea()hookRe-implementation details
Instead of a single triangle, we draw four now, but they cover possible scenarios unlike before. The previous implementation supported only this case (when a trigger is smaller then a container):
2025-06-18.17.40.56.mp4
Updated implementation supported a vice-versa case too:
2025-06-18.17.40.14.mp4
The rendering was also switches to React instead of direct DOM updates as it became too complicated.
Related Issue(s)