WIP/DNM: Comparing MSHV changes with main branch #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oud-hypervisor (#2) * Code for kernelPath; scripts for additionalRpms * Remove custom path of libvirtd and virtlogd * Readd return err code if loaddomcapabilities fails * Use modular virtchd daemon for CH --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
* Add script for running make test * Fix typo in run-mshv-tests.sh * Change hypervisor to ch in EnsureKVMPresent() fn * List /dev/mshv device * Add command to focus run tests * Able to run kubectl_test.go but it fails * Remove libvmi.WithRng() option from Fedora VM creation function * Set kubeconfig and set -x * Set kubectl path if not specified * Verified container_disk_tests.go run * Add WithHypervisor field * Fix comments * Increase functest timeout to 24h * Add CH hypervisor to VMIs created in sig-compute * Expose KUBEVIRT_FUNC_TEST_TIMEOUT; shorten kubectl and kubeconfig setting --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
…#6) Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
* Add Hypervisor in VMI spec in instancetype/instancetype.go * Add hypervisor spec and remove unsupported devs in storage.go --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
* Set SupportsISO=true for CH * Remove SupportsISO function from Hypervisor interface --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
* Other changes * Comment out CAP_SYS_ADMIN * Reindentation * Capture virtchd logs * Add KV build scripts * Remove CAP_SYS_ADMIN comment too * Add CAP_NET_ADMIN * remove build scripts * Revert pkg/virt-controller/services/renderresources.go * Remove CAP_SYS_ADMIN * Revert to using /etc/libvirt/vmm.conf * Add resource requirement to CH virt-launcher pod * Add ch.conf * Fix logic to detec the vmmDaemon process * Remove old comment --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
* SetupLibvirt for CH * Separate QEMU and CH implementation to different files * UNSTABLE Moved functions to hypervisor interface * Able to compile * Expose GetLibvirtLogFilters fn. * Add missing GetDomainType function in QEMU and CH hypervisor impls * Rename root() to Root(); Remove vmm field in hypervisors --------- Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note