You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR: The logic in virt-launcher that is agnostic of the underlying virtualization stack (e.g., gRPC server for managing VM, DomainManager interface, NotifyClient) was in the same package as the virtualization-stack-specific code.
After this PR: Virtualization-stack-agnostic code has been moved to a separate package called virt-launcher-common. The libvirt/qemu/kvm-specific logic in virt-launcher is left in the virt-launcher package. virt-launcher-common does not depend on any code in the libvirt-specific virt-launcher package.
This change is really massive. How can we stage these changes to prevent such a massive PR?
@JocelynBerrendonner I agree that the PR has a very large number of files that are changed. The vast majority of files updated simply have changes to import statements. This is because a lot of the common code in virt-launcher has been moved to virt-launcher-common. Since a lot of other code depends on that core part of virt-launcher's functionality, it necessitated import statement changes in a large number of files.
A potential alternative approach is to let the common parts of virt-launcher remain where they are currently and, instead, move the Libvirt/QEMU/KVM-specific code into another folder named virt-launcher-libvirt-qemu. Although it might also need a number of files to be moved, the PR footprint might be smaller.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR: The logic in virt-launcher that is agnostic of the underlying virtualization stack (e.g., gRPC server for managing VM, DomainManager interface, NotifyClient) was in the same package as the virtualization-stack-specific code.
After this PR: Virtualization-stack-agnostic code has been moved to a separate package called
virt-launcher-common. The libvirt/qemu/kvm-specific logic in virt-launcher is left in thevirt-launcherpackage.virt-launcher-commondoes not depend on any code in the libvirt-specificvirt-launcherpackage.