added no-asm to the config flag for openssl build #5109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5109 +/- ##
==========================================
- Coverage 86.03% 85.43% -0.61%
==========================================
Files 59 59
Lines 18035 18035
==========================================
- Hits 15517 15408 -109
- Misses 2518 2627 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As mentioned over IM, we can't take this even if it fixes some internal build issues. No assembly would hurt perf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
MSQuic builds fail for amd64 using native compiler. It found that the issue is the assembly implementation of openssl doesnt support control flow guards. Adding no-asm to the config flags fixes the issue.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?