Skip to content

fix(test): fix unit tests in pkg capture #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alexcastilio
Copy link
Contributor

Description

Unit tests for this pkg were failing. E.g. https://github.com/microsoft/retina/actions/runs/15751219397/job/44396605626
image

This PR fixes problems in pkg.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Unit test for pkg:

$ go test ./pkg/capture/...
ok      github.com/microsoft/retina/pkg/capture 0.505s
?       github.com/microsoft/retina/pkg/capture/constants       [no test files]
?       github.com/microsoft/retina/pkg/capture/file    [no test files]
ok      github.com/microsoft/retina/pkg/capture/outputlocation  0.007s
?       github.com/microsoft/retina/pkg/capture/outputlocation/managed  [no test files]
ok      github.com/microsoft/retina/pkg/capture/provider        0.006s
ok      github.com/microsoft/retina/pkg/capture/utils   0.009s

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
@alexcastilio alexcastilio requested a review from kamilprz June 19, 2025 12:23
@alexcastilio alexcastilio requested a review from a team as a code owner June 19, 2025 12:23
@alexcastilio alexcastilio requested a review from estebancams June 19, 2025 12:23
Signed-off-by: Alex Castilio <alexsantos@microsoft.com>
Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-unit-test-pkg-capture branch from e5bd32c to 397f06d Compare June 19, 2025 13:35
Signed-off-by: Kamil <kamil.prz@gmail.com>
@kamilprz
Copy link
Contributor

make test results

{9F0E4463-FE1A-4045-B734-035E2E3AEEBF}

@kamilprz kamilprz added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants