Small enhancements for VS profile generation #19025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reynoldskr
force-pushed
the
dev/reynoldskr/vs_profile_fix_arm64
branch
from
23186b5 to
1142b6c
Compare
DHowett
reviewed
Jun 12, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
ah, clang-format is of course upset |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 19025 in repo microsoft/terminal |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
approved these changes
Jun 13, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hmm. It's running, it just isn't reporting status properly. |
|
Looks like it all finished now? |
DHowett
pushed a commit
that referenced
this pull request
Jun 17, 2025
* Make PowerShell profile generation try to find `pwsh.exe` before falling back to legacy powershell * Make profiles generated on an `arm64` host work properly ## Validation Steps Performed * Local build ran * Verified the new `arm64` profile works * Verified `pwsh.exe` is used if present * Verified `powershell.exe` is used if `pwsh` is not present in path * Verified we don't attempt to create `arm64` host cmd/pwsh profiles if VS is not >= 17.4 (cherry picked from commit bb62ce9) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgbeRwk Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Jun 17, 2025
* Make PowerShell profile generation try to find `pwsh.exe` before falling back to legacy powershell * Make profiles generated on an `arm64` host work properly ## Validation Steps Performed * Local build ran * Verified the new `arm64` profile works * Verified `pwsh.exe` is used if present * Verified `powershell.exe` is used if `pwsh` is not present in path * Verified we don't attempt to create `arm64` host cmd/pwsh profiles if VS is not >= 17.4 (cherry picked from commit bb62ce9) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgbeRwg Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
pwsh.exebefore falling back to legacy powershellarm64host work properlyValidation Steps Performed
arm64profile workspwsh.exeis used if presentpowershell.exeis used ifpwshis not present in patharm64host cmd/pwsh profiles if VS is not >= 17.4 (thanks @DHowett)