Local Containers #19502
Merged
Local Containers #19502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 6, 2025 15:39
…ionality is done, just need to flesh out ui
|
aasimkhan30
reviewed
Jun 6, 2025
media/newContainer_dark.svg
Outdated
There was a problem hiding this comment.
NIT: These icons look more like the server icon. Maybe we can use better icons. Something like this with +sign.
laurenastrid1
force-pushed
the
laurennat/localContainers
branch
from
3d2a07a to
59fceb8
Compare
added 2 commits
June 6, 2025 11:42
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
| return sanitized; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
NIT: add link to the password policy.
There was a problem hiding this comment.
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
reviewed
Jun 6, 2025
| const containerIds = stdout.split("\n").filter(Boolean); | ||
| if (!containerIds.length) return startPort; | ||
|
|
||
| const usedPorts = await getUsedPortsFromContainers(containerIds); |
There was a problem hiding this comment.
NIT: what if the port is used by something other than docker.
aasimkhan30
reviewed
Jun 6, 2025
src/containerDeployment/containerDeploymentWebviewController.ts
Outdated
Show resolved
Hide resolved
aasimkhan30
reviewed
Jun 6, 2025
src/containerDeployment/containerDeploymentWebviewController.ts
Outdated
Show resolved
Hide resolved
aasimkhan30
reviewed
Jun 6, 2025
| // doing it this way instead of directly calling startContainer | ||
| // allows for the object explorer item loading UI to show | ||
| this._objectExplorerProvider.deleteChildrenCache(node); | ||
| await this._objectExplorerProvider.setNodeLoading(node); |
There was a problem hiding this comment.
NIT: Maybe this code should have been added in OE service so that we can keep track of everything in one place.
aasimkhan30
reviewed
Jun 6, 2025
aasimkhan30
approved these changes
Jun 6, 2025
aasimkhan30
approved these changes
Jun 9, 2025
|
@aasimkhan30 merged it in for me because of my github permissions bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Tmplate – vscode-mssql
Description
Scenarios
User tries to make a new Docker container, and Docker is not installed. The extension prompts the user to install Docker.
User tries to make a new Docker container, and Docker is not started. The extension then attempts to start Docker.
User tries to make a new Docker container, but something is wrong with the engine (e.g., Windows containers, no user privilege to run Docker engine commands on Linux, Rosetta not enabled on Mac). On Windows platforms, the extension will prompt the user to switch to linux containers; if they accept the prompt, then the extension will switch to linux containers for them. On Linux and Mac, the extension will notify the user what the problem with the engine is.
User makes a new Docker container without a custom container name or port. The extension will use the default name of the container, which will be sql_server_container_{number}, and use the default port for container, which will be the next available port beginning at 1433
User makes a new Docker container with a custom container name and port. If the user tries to use a port/container name already in use, they will be prompted for a unique input.
User adds a Docker container through the connection dialog, and the extension detects that it's a Docker container.
User starts Docker container through the extension.
User stops Docker container through the extension.
User deletes Docker container through the extension.
Test Coverage:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines