-
Notifications
You must be signed in to change notification settings - Fork 500
Transferring active connection when opening a new SQL file #19503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Changes
|
I'm glad to see this here, since it seems to be related to my issue (#19477)! However, the way this code seems to be set up (and I freely admit ignorance of the VSC codebase), it's unclear what would happen if a new tab were opened while a query is pending or running in the existing tab. It's fine to transfer connections when there is no active query work going on. But if I have a query pending or running in Tab 1 and I open an SQL file creating Tab 2 (or just open a new query tab), I would want my query to continue running in Tab 1 and show its results there, but I would also want Tab 2 to auto-connect to the same database fluently. Ideally in a way that doesn't make me pause my work to wait for it to connect or update IntelliSense in order to run the new query. And certainly in a way that doesn't require me to manually choose the connection again (the current state). |
@richardtallent-erm , As a result: |
Pull Request Template – vscode-mssql
Description
Fixes #19477
Automatically transfers connection from the active SQL file to a newly-opened SQL file.
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines