Skip to content

fixing schema designer perf #19521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2025
Merged

fixing schema designer perf #19521

merged 7 commits into from
Jun 6, 2025

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Jun 1, 2025

Pull Request Template – vscode-mssql

Description

Fixes #19168, Fixes #19474

  1. Updates fluent ui react to the latest version. This brings the list component out of the preview so we don't need an additional package "@fluentui/react-list-preview" to include it.
  2. Renames the GetScript API to GetDefinition to better match the UI text.
  3. Updated the target table dropdown in foreing key editor to Searchable dropdown to keep it consistent with other dropdowns.
  4. Making sure we turn off react flow virtualization when we export the diagram as an image so that we are rendering all then nodes.
  5. When generating report for the changes, I am changing from a modal dialog that blocks the diagram to a vscode notification.
    Before:

image

After: (Publish button gets disable as we don't want users to press it twice.
image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

github-actions bot commented Jun 1, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 58.72% 58.60% ⚪ 0.00%
VSIX Size 15305 KB 15297 KB ⚪ -8 KB ( 0% )
Webview Bundle Size 3692 KB 3616 KB 🟢 -76 KB ( -2% )

@aasimkhan30 aasimkhan30 changed the title Aasim/feat/newapisd fixing schema designer perf Jun 2, 2025
@aasimkhan30 aasimkhan30 merged commit 486fa1e into main Jun 6, 2025
4 of 5 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/feat/newapisd branch June 6, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Loading Schema Designer gets stuck with several tables Schema Designer - Initial loading is slow
2 participants