Adding Connection Groups #19536
Merged
Adding Connection Groups #19536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Changes
|
Benjin
requested review from
kburtram,
aasimkhan30,
caohai,
laurenastrid1 and
lewis-sanchez
as code owners
aasimkhan30
reviewed
Jun 9, 2025
aasimkhan30
reviewed
Jun 9, 2025
aasimkhan30
approved these changes
Jun 10, 2025
caohai
approved these changes
Jun 10, 2025
caohai
approved these changes
Jun 10, 2025
Benjin
added a commit
that referenced
this pull request
Jun 10, 2025
* loading OE from config * checkpoint - updating nodes in OE broken * checkpoint - fixing string * Dialog launching * Initial UI * core UI * re-merging group manager into connection config * some cleanup * connDialog checkpoint * Integration into connection dialog * loc * Pre-cursor * Tree reveal fixed, children expand state not preserved * cleanup * ...working? * Adding color support for folder icon * light theme support for icon * Refresh folder structure when editing group config * adding color picker * adding entrypoints to connection group tree items * Adding description tooltip and keyboard handling * adding drag/drop * cleaning up onConnectionChange logic * PR cleanup * Fixing existing tests * updated yarn lock * cleanup * Loc * adding tests * PR feedback * adding additonal telemetry * handling nested group removals
kburtram
pushed a commit
that referenced
this pull request
Jun 11, 2025
* loading OE from config * checkpoint - updating nodes in OE broken * checkpoint - fixing string * Dialog launching * Initial UI * core UI * re-merging group manager into connection config * some cleanup * connDialog checkpoint * Integration into connection dialog * loc * Pre-cursor * Tree reveal fixed, children expand state not preserved * cleanup * ...working? * Adding color support for folder icon * light theme support for icon * Refresh folder structure when editing group config * adding color picker * adding entrypoints to connection group tree items * Adding description tooltip and keyboard handling * adding drag/drop * cleaning up onConnectionChange logic * PR cleanup * Fixing existing tests * updated yarn lock * cleanup * Loc * adding tests * PR feedback * adding additonal telemetry * handling nested group removals
This was referenced Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18652
Adds support for connection groups, with:
Connection.groups.mp4
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines