Skip to content

Porting "Adding Connection Groups (#19536)" #19561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Jun 10, 2025

Original PR: #19536

Bug: Fixes #18652

Adds support for connection groups, with:

  • colored group folders
  • drag and drop to reorganize
  • create groups from within the connection dialog or independently

* loading OE from config

* checkpoint - updating nodes in OE broken

* checkpoint - fixing string

* Dialog launching

* Initial UI

* core UI

* re-merging group manager into connection config

* some cleanup

* connDialog checkpoint

* Integration into connection dialog

* loc

* Pre-cursor

* Tree reveal fixed, children expand state not preserved

* cleanup

* ...working?

* Adding color support for folder icon

* light theme support for icon

* Refresh folder structure when editing group config

* adding color picker

* adding entrypoints to connection group tree items

* Adding description tooltip and keyboard handling

* adding drag/drop

* cleaning up onConnectionChange logic

* PR cleanup

* Fixing existing tests

* updated yarn lock

* cleanup

* Loc

* adding tests

* PR feedback

* adding additonal telemetry

* handling nested group removals
Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 59.26% 59.54% ⚪ 0.00%
VSIX Size 15359 KB 15364 KB ⚪ 5 KB ( 0% )
Webview Bundle Size 3712 KB 3712 KB ⚪ 0 KB ( 0% )

@kburtram kburtram merged commit 3352770 into release/1.33 Jun 11, 2025
5 checks passed
@kburtram kburtram deleted the port/benjin/19536 branch June 11, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants