Fix result grid losing scroll state when switching query editors. #19670
+213
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new enums for scroll position management in singletonStore. - Implemented methods to set and get grid scroll positions in the table and utils. - Updated QueryResultPane to load and store scroll positions on scroll events.
…e unnecessary logging and adjust row height constant
aasimkhan30
requested review from
kburtram,
caohai,
laurenastrid1,
lewis-sanchez and
Benjin
as code owners
PR Changes
|
…X constant and use viewport dimensions for scroll position updates
aasimkhan30
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
This PR fixes #18666
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines