Fixing always encrypted column results for AKV keys. #19687
+338
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasimkhan30
requested review from
kburtram,
caohai,
laurenastrid1,
lewis-sanchez and
Benjin
as code owners
PR Changes
|
Benjin
approved these changes
Jul 3, 2025
src/controllers/connectionManager.ts
Outdated
| @@ -117,6 +117,7 @@ export default class ConnectionManager { | |||
| this._onConnectionsChangedEmitter.event; | |||
|
|
|||
| public initialized: Deferred<void> = new Deferred<void>(); | |||
| private _keyVaultTokenCache: Map<string, IToken> = new Map<string, IToken>(); | |||
There was a problem hiding this comment.
Can you add some unit tests that cover this request and the caching behavior?
…roved readability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
This PR fixes #1656
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines