-
Notifications
You must be signed in to change notification settings - Fork 506
Add collapse/expand button for tables with more than 10 columns #19692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com>
Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com>
The issue refers to schema designer table nodes having many columns. The current fix is targets an unrelated area (table designer) in the code. |
You're absolutely right. I mistakenly implemented the feature in the Table Designer instead of the Schema Designer table nodes. I'll revert the incorrect changes and implement the collapse/expand functionality in the proper location for schema designer table nodes.
Fixed in commit fbd832c. I've reverted the incorrect Table Designer changes and properly implemented the collapse/expand feature in the Schema Designer table nodes where it belongs. The feature now correctly targets the table nodes in the schema diagram view as specified in issue #19114. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…le nodes Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com>
Can you make the default state collapsed? Users can expand the nodes if needed. Moreover, on collapse, all the relationships are getting hidden. Instead consolidate them between the last visible column and the expand button and when the node is expanded they go back to the columns they belong to. |
PR Changes
|
I've implemented the requested changes:
The implementation ensures that relationship connections are maintained even when columns are hidden, addressing the issue where relationships were getting completely hidden during collapse. |
Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com>
This PR implements a collapse/expand feature for tables in the Table Designer to improve usability when working with tables containing many columns (e.g., over 100 columns as shown in the issue).
Problem
Tables with a large number of columns were difficult to navigate and read, significantly impacting user experience. The absence of a collapse/expand button made it challenging to work with wide tables.
Solution
Added an intelligent collapse/expand button that:
Key Features
✅ Smart Button Display: Only appears when table has >10 columns
✅ Optimized View: Shows first 10 data columns when collapsed
✅ Action Columns Preserved: Drag handle and remove buttons always visible
✅ Visual Feedback: Chevron icons indicate current state
✅ Localization Ready: Button text supports internationalization
✅ Performance Optimized: Zero impact on tables with ≤10 columns
Technical Implementation
useState
getVisibleColumns()
function to filter columns based on collapsed stateTesting
Fixes #19114.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.