Skip to content

Modify Run Selection/Line to reuse existing terminal #25178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s-kai273
Copy link

@s-kai273 s-kai273 commented Jun 13, 2025

Summary

To fix #24960, I implemented a new function to reuse an existing terminal on Run Selection/Line.

What was done

  • Implement the feature
  • Implement test cases

@s-kai273
Copy link
Author

@anthonykim1
Hi, I’ve implemented a rough version of this feature and confirmed that it works as expected in my local environment.

As for the basic implementation approach, I’ve created ExternalTerminalService that implements ITerminalService.
Since the existing TerminalService is designed to execute commands only within terminals it creates, my plan is to switch between the two based on the option value.

I’m aware that further refactoring is needed, but I’d like to confirm whether this overall implementation direction looks okay to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Selection/Line in already active python interpreter terminal rather than opening a new terminal
2 participants