Log x-vss-e2eid and activityid headers on Marketplace errors

[isidorn]

Related to https://github.com/microsoft/vscode-engineering/issues/1011

We should log the x-vss-e2eid and activityid headers from Marketplace response on publish errors.
This will help the MP team find the root cause of the publish errors better.

@joelverhagen let us know if anything else is needed

[joelverhagen]

Yes, these two headers are common values that you can correlate to Azure DevOps (and by extension Marketplace) logs. They are very useful. Would the result be information logged to stdout? Or would it be sent to VS Code Kusto telemetry?

This issue seems specific to vsce. Does this share code with VS Code client when interacting with Marketplace? I think that path too could benefit from including these response headers.

[isidorn]

fyi @sandy081

[benibenj]

We believe this is signing related and outside the scopes of VSCE. VSCE does not have access to the headers as it uses the azure-devops-node-api to handle these requests. We suggest trying to correlate the failed publishing requests (mentioned here https://github.com/microsoft/vscode-engineering/issues/1011) based on timestamp and extension id with telemetry to get more insights.

[joelverhagen]

I do not have access to the https://github.com/microsoft/vscode-engineering/issues/1011 URL. Could I be added?

I was unable to correlate that particular failure just based on timestamp. I will follow up over Teams on this issue.

The VS Marketplace team does not own that npm module. It looks like the public tracker for it is here:
https://github.com/microsoft/azure-devops-node-api/issues

I think you should create an issue on that repo asking how to get ActivityId or X-VSS-E2EID.

I see ActivityId mentioned in some
INotificationDiagnosticLog but I am not sure if that's related to your flow.
https://github.com/microsoft/azure-devops-node-api/blob/1d8f29c52c10a1fa875b04c9add5198ef1db54a2/api/interfaces/NotificationInterfaces.ts#L317

[isidorn]

fyi @joaomoreno

so I am not the middle-men in this discussion :)

[joaomoreno]

I do not have access to the microsoft/vscode-engineering#1011 URL. Could I be added?

✅