-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Open
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitieswebview-viewsWebview views in the sidebar and panelWebview views in the sidebar and panel
Milestone
Description
Originally in microsoft/vscode-pull-request-github#4872 (comment)
Here is what I see happen:
- Open a folder
- Have an extension that creates a webview view
- Keep the webview view open
- Add a folder to the workspace, which causes the extension host to be restarted.
- The extension's
deactivate
gets called as expected. Indeactivate
the extensiondispose
s of the webview view provider. - With this
dispose
I would expect the webview view to hide, but it does not.
You can easily reproduce the above using the GitHub Pull Request extension with the steps linked from the original issue.
juancampa, zephraph, aranajhonny, federico-terzi-anima, snreinert and 4 more
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitieswebview-viewsWebview views in the sidebar and panelWebview views in the sidebar and panel
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
juancampa commentedon May 3, 2024
+1 on this. Our webview stays open but there's no one listening for messages so it just doesn't work. i.e. messages sent via
postMessage
don't go anywhere.I'm wondering if anyone has come up with a work-around.
juancampa commentedon May 3, 2024
Our current workaround is to search for orphaned webviews during
activate
, and close/reopen them.In case this could help others:
Reap or recreate ISL when extension host is restarted