-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Open
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugconfirmedIssue has been confirmed by VS Code Team memberIssue has been confirmed by VS Code Team membertitlebarVS Code main title bar issuesVS Code main title bar issueswebIssues related to running VSCode in the webIssues related to running VSCode in the web
Milestone
Description
- VS Code Version: 1.97.0-insider
- OS Version: PWA (Mac OS, but should apply to all)
Steps to Reproduce:
- Set the colour
titleBar.inactiveBackground
to something significantly different to theactiveBackground
to easily distinguish the focused app. - Focus on any other app.
Notice that even when the PWA is inactive, it still takes the theme-color from the active titlebar background.
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/style.ts#L27-L41
I think that ideally the theme-color would match the titlebar colour, regardless of whether the app is active or not.
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugconfirmedIssue has been confirmed by VS Code Team memberIssue has been confirmed by VS Code Team membertitlebarVS Code main title bar issuesVS Code main title bar issueswebIssues related to running VSCode in the webIssues related to running VSCode in the web
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
benibenj commentedon Dec 20, 2024
I was able to fix the reported problem, and the title bar renders correctly when merged together with the PWA title bar. When the title bar is not merged with the PWA title bar, there seems to be a border with a different color...
https://github.com/user-attachments/assets/b7b01392-9402-42a6-9e93-96548a51f74e