Skip to content

theme-color is not updated when the PWA is inactive. #236615

@a-stewart

Description

@a-stewart
Contributor
  • VS Code Version: 1.97.0-insider
  • OS Version: PWA (Mac OS, but should apply to all)

Steps to Reproduce:

  1. Set the colour titleBar.inactiveBackground to something significantly different to the activeBackground to easily distinguish the focused app.
  2. Focus on any other app.

Image

Notice that even when the PWA is inactive, it still takes the theme-color from the active titlebar background.

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/style.ts#L27-L41

I think that ideally the theme-color would match the titlebar colour, regardless of whether the app is active or not.

Activity

assigned and unassigned on Dec 20, 2024
added
titlebarVS Code main title bar issues
webIssues related to running VSCode in the web
on Dec 20, 2024
assigned and unassigned on Dec 20, 2024
added
help wantedIssues identified as good community contribution opportunities
confirmedIssue has been confirmed by VS Code Team member
bugIssue identified by VS Code Team member as probable bug
and removed on Dec 20, 2024
added this to the Backlog milestone on Dec 20, 2024
removed
help wantedIssues identified as good community contribution opportunities
on Dec 20, 2024
benibenj

benibenj commented on Dec 20, 2024

@benibenj
Contributor

I was able to fix the reported problem, and the title bar renders correctly when merged together with the PWA title bar. When the title bar is not merged with the PWA title bar, there seems to be a border with a different color...
https://github.com/user-attachments/assets/b7b01392-9402-42a6-9e93-96548a51f74e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugconfirmedIssue has been confirmed by VS Code Team membertitlebarVS Code main title bar issueswebIssues related to running VSCode in the web

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @a-stewart@bpasero@aeschli@benibenj

    Issue actions

      theme-color is not updated when the PWA is inactive. · Issue #236615 · microsoft/vscode