-
Notifications
You must be signed in to change notification settings - Fork 34.3k
Open
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityterminal-suggest
Milestone
Description
Instead of importing all specs up front:
vscode/extensions/terminal-suggest/src/terminalSuggestMain.ts
Lines 48 to 55 in ec82ef2
export const availableSpecs: Fig.Spec[] = [ | |
cdSpec, | |
codeInsidersCompletionSpec, | |
codeCompletionSpec, | |
]; | |
for (const spec of upstreamSpecs) { | |
availableSpecs.push(require(`./completions/upstream/${spec}`).default); | |
} |
We should support lazy loading of the files by generating an index file that includes only the information required to show the command information which currently is just the name and description:
Then if the user requests completions for an argument, we would load the spec via an await import
.
This will help performance and memory consumption scaling as we add more specs.
meganrogge
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityterminal-suggest