Recent workspace picker experience is inconsistent

[joaomoreno]

Typing in the recently opened workspaces picker feels random. Notice how I type tools. Pretty much, vscode-tools is the one I open the most and have opened the most recently. Yet, not only it never shows up in first place, but it keeps jumping up and down the more I narrow it down.

Screen.Recording.2025-04-22.at.21.52.33.mov

Ideally we never change the sort order of this list, even as the user narrows it down. Most recent repos should always stay at the top. It feels like a regression... is it?

[TylerLeonhardt]

I haven't touched this... @bpasero have you? I don't know if this part is owned by you or if I inherited it with Command Palette and Quick Access

[TylerLeonhardt]

Ah... so it's this code:

vscode/src/vs/workbench/browser/actions/windowActions.ts

Lines 140 to 144 in 16ee4a7

	const pick = await quickInputService.pick(picks, {
	contextKey: inRecentFilesPickerContextKey,
	activeItem: [...workspacePicks, ...filePicks][autoFocusSecondEntry ? 1 : 0],
	placeHolder: isMacintosh ? localize('openRecentPlaceholderMac', "Select to open (hold Cmd-key to force new window or Option-key for same window)") : localize('openRecentPlaceholder', "Select to open (hold Ctrl-key to force new window or Alt-key for same window)"),
	matchOnDescription: true,

which just uses .pick(...)

so this must be a bug in quick pick... I gotta see how we handle sortByLabel

[bpasero]

The workspace history uses a normal picker, which to my knowledge does not have the smarts for fuzzy search and sorting that e.g. the files picker has.