Skip to content

Terminal: Run Recent Command shows up when there are no terminals #233604

New issue
New issue
Closed
#250799
Closed
Terminal: Run Recent Command shows up when there are no terminals#233604
#250799
Assignees
Tyriar
Labels
bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code Insidersterminal-shell-integrationShell integration infrastructure, command decorations, etc.
Milestone
 
June 2025
@Tyriar

Description

@Tyriar
Tyriar
opened on Nov 11, 2024
Member

Repro:

  1. Close all terminals
  2. Run the command, 🐛 nothing happens

Image

We should either hide it or implement it when there isn't a terminal.

Activity

Tyriar
added
bugIssue identified by VS Code Team member as probable bug
help wantedIssues identified as good community contribution opportunities
terminal-shell-integrationShell integration infrastructure, command decorations, etc.
on Nov 11, 2024
Tyriar
added this to the Backlog milestone on Nov 11, 2024
Tyriar
self-assigned this
on Nov 11, 2024
SalerSimo

SalerSimo commented on Nov 18, 2024

@SalerSimo
SalerSimo
on Nov 18, 2024

@Tyriar can i help with this issue?

Tyriar

Tyriar commented on Nov 18, 2024

@Tyriar
Tyriar
on Nov 18, 2024
MemberAuthor

@SalerSimo sure! Here's a code pointer:

vscode/src/vs/workbench/contrib/terminalContrib/history/browser/terminal.history.contribution.ts

Lines 141 to 152 in e354996

run: async (activeInstance, c) => {
const history = TerminalHistoryContribution.get(activeInstance);
if (!history) {
return;
}
await history.runRecent('command');
if (activeInstance?.target === TerminalLocation.Editor) {
await c.editorService.revealActiveEditor();
} else {
await c.groupService.showPanel(false);
}
}

SalerSimo
mentioned this on Nov 18, 2024
SalerSimo

SalerSimo commented on Nov 21, 2024

@SalerSimo
SalerSimo
on Nov 21, 2024

@Tyriar I opened a PR for this, can you tell me if the code I wrote is fine? I'm not sure if using a sleep function is accepted here, and, if it's not, I think that the only solution for this issue would be hiding the "Run Recent Command" command when there are no open terminals.

Sublimeful
mentioned this on Jun 6, 2025
Sublimeful

Sublimeful commented on Jun 6, 2025

@Sublimeful
Sublimeful
on Jun 6, 2025
Contributor

@Tyriar Since there has been no recent activity on this issue, I have created a PR that addresses this. If you have time, please take a look at the PR and let me know if you have any questions!

Tyriar
modified the milestones: Backlog, June 2025 on Jun 6, 2025
Tyriar
closed this as completedin #250799on Jun 6, 2025
vs-code-engineering
added
unreleasedPatch has not yet been released in VS Code Insiders
on Jun 6, 2025

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code Insidersterminal-shell-integrationShell integration infrastructure, command decorations, etc.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    Participants

    @Tyriar@Sublimeful@SalerSimo

    Issue actions
      Terminal: Run Recent Command shows up when there are no terminals · Issue #233604 · microsoft/vscode