Skip to content

Multi-command support for terminal suggest #241993

New issue
New issue
Closed
#250910
Closed
Multi-command support for terminal suggest#241993
#250910
Assignees
Tyriarmeganroggecopilot-swe-agent
Labels
feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersterminal-suggest
Milestone
 
June 2025
@mjbvz

Description

@mjbvz
mjbvz
opened on Feb 26, 2025 · edited by Tyriar
Collaborator

Testing #241771

  1. On windows, try suggestions for ls && git |

bug
No suggestion show up. Works fine with just git |

Image

EDIT from @Tyriar

Second verify case:

  • Suggest on echo a ; echo in pwsh to make sure ; is handled.

Activity

mjbvz
assigned
Tyriar
and
meganrogge
on Feb 26, 2025
meganrogge

meganrogge commented on Feb 26, 2025

@meganrogge
meganrogge
on Feb 26, 2025
Contributor

A wider view of your terminal would be helpful - what shell are you using?

meganrogge
added
info-neededIssue requires more information from poster
on Feb 26, 2025
mjbvz

mjbvz commented on Feb 26, 2025

@mjbvz
mjbvz
on Feb 26, 2025
CollaboratorAuthor

Powershell:

Image

Only the recent suggestion shows up, not the smart ones for git

meganrogge

meganrogge commented on Feb 26, 2025

@meganrogge
meganrogge
on Feb 26, 2025
Contributor

If git is the first on the line, what shows up?

mjbvz

mjbvz commented on Feb 26, 2025

@mjbvz
mjbvz
on Feb 26, 2025
CollaboratorAuthor

It works fine in that case, just not after any command separators

Image
meganrogge
added
bugIssue identified by VS Code Team member as probable bug
terminal-suggest
and removed
info-neededIssue requires more information from poster
on Feb 26, 2025
meganrogge
added this to the February 2025 milestone on Feb 26, 2025
Tyriar

Tyriar commented on Feb 26, 2025

@Tyriar
Tyriar
on Feb 26, 2025
Member

Code pointer:

vscode/extensions/terminal-suggest/src/tokens.ts

Lines 8 to 32 in 949b5cf

export const enum TokenType {
Command,
Argument,
}
const shellTypeResetChars: { [key: number]: string[] | undefined } = {
[TerminalShellType.Bash]: ['>', '>>', '<', '2>', '2>>', '&>', '&>>', '|', '|&', '&&', '||', '&', ';', '(', '{', '<<'],
[TerminalShellType.Zsh]: ['>', '>>', '<', '2>', '2>>', '&>', '&>>', '<>', '|', '|&', '&&', '||', '&', ';', '(', '{', '<<', '<<<', '<('],
[TerminalShellType.PowerShell]: ['>', '>>', '<', '2>', '2>>', '*>', '*>>', '|', '-and', '-or', '-not', '!', '&', '-eq', '-ne', '-gt', '-lt', '-ge', '-le', '-like', '-notlike', '-match', '-notmatch', '-contains', '-notcontains', '-in', '-notin']
};
const defaultShellTypeResetChars = shellTypeResetChars[TerminalShellType.Bash]!;
export function getTokenType(ctx: { commandLine: string; cursorPosition: number }, shellType: TerminalShellType | undefined): TokenType {
const spaceIndex = ctx.commandLine.substring(0, ctx.cursorPosition).lastIndexOf(' ');
if (spaceIndex === -1) {
return TokenType.Command;
}
const previousTokens = ctx.commandLine.substring(0, spaceIndex + 1).trim();
const commandResetChars = shellType === undefined ? defaultShellTypeResetChars : shellTypeResetChars[shellType] ?? defaultShellTypeResetChars;
if (commandResetChars.some(e => previousTokens.endsWith(e))) {
return TokenType.Command;
}
return TokenType.Argument;
}

I think fig may need to get the command line starting with the second command (git of ls && git) which we might not do do currently. Let's move this out as we know support for this is very basic currently.

Tyriar
modified the milestones: February 2025, March 2025 on Feb 26, 2025
Tyriar
mentioned this on Feb 26, 2025

18 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersterminal-suggest

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    Participants

    @Tyriar@mjbvz@meganrogge

    Issue actions
      Multi-command support for terminal suggest · Issue #241993 · microsoft/vscode