Skip to content

Terminal state's shell type should be faster #247070

@anthonykim1

Description

@anthonykim1

From:
#245698 (comment)

It seems like for mac, creating terminal and then checking its shell type right away yields right shell type, but for Windows it takes a listener of onDidChangeTerminalState to subscribe and listen to shell type event to get the desired shell type.

This could be faster otherwise limited by how we detect shell type since shell type should be obvious at the moment of creating Terminal.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions