-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Labels
authentication-githubIssues with the GitHub Authentication extensionIssues with the GitHub Authentication extensionfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-testplan
Milestone
Description
When logging into GitHub from an extension, we end up with:
The main CTA in the web appears to be Cancel.
We have 3 flow options:
- Auto-redirect back to VS Code (which may be the nicest, but it does have the above confirmation)
- Redirecting to a localhost server which doesn't bring you back to VS Code but lands you on a page that says something to the effect of "you can close this tab"
- The device code flow
We could run an experiment to make the redirect to local host the default and compare the drop off rate to the auto-redirect.
We could look to still use the protocol link to open VS Code from that localhost page, so we would get the best of 2 worlds:
- sign-in completes in all cases and will never hang
- we can still bring VS Code to the front via protocol link
bpaseroCopilot
Metadata
Metadata
Labels
authentication-githubIssues with the GitHub Authentication extensionIssues with the GitHub Authentication extensionfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-testplan
Activity
TylerLeonhardt commentedon Jun 11, 2025
In #250570 I implemented a similar flow for dynamic auth providers used in MCP. It:
We can just do this as the primary flow for GitHub Authentication.
bpasero commentedon Jun 11, 2025
Yes I really like that 🙏 . I wonder if we could both try to open VS Code again and also redirect to some AI landing page on our main website for further reading.
Have Loopback Server flow redirect back to VS Code and make it the pr…
TylerLeonhardt commentedon Jun 12, 2025
Alright #251333 has the change to:
This would be a bigger change... one where we'd need API in
getSession
to allow a redirect uri to land on.16 remaining items