Skip to content

Explore different login paths #250086

@bamurtaugh

Description

@bamurtaugh
Member

When logging into GitHub from an extension, we end up with:

Image

The main CTA in the web appears to be Cancel.

We have 3 flow options:

  • Auto-redirect back to VS Code (which may be the nicest, but it does have the above confirmation)
  • Redirecting to a localhost server which doesn't bring you back to VS Code but lands you on a page that says something to the effect of "you can close this tab"
  • The device code flow

We could run an experiment to make the redirect to local host the default and compare the drop off rate to the auto-redirect.

We could look to still use the protocol link to open VS Code from that localhost page, so we would get the best of 2 worlds:

  • sign-in completes in all cases and will never hang
  • we can still bring VS Code to the front via protocol link

Activity

added this to the Backlog milestone on May 30, 2025
removed their assignment
on Jun 2, 2025
TylerLeonhardt

TylerLeonhardt commented on Jun 11, 2025

@TylerLeonhardt
Member

In #250570 I implemented a similar flow for dynamic auth providers used in MCP. It:

  • redirect to a localhost:XXXX domain that says "you did it"
  • after 1s that page redirects back to VS Code

We can just do this as the primary flow for GitHub Authentication.

bpasero

bpasero commented on Jun 11, 2025

@bpasero
Member

Yes I really like that 🙏 . I wonder if we could both try to open VS Code again and also redirect to some AI landing page on our main website for further reading.

TylerLeonhardt

TylerLeonhardt commented on Jun 12, 2025

@TylerLeonhardt
Member

Alright #251333 has the change to:

  • have the localhost/loopback flow redirect back to VS Code
  • make this new hybrid flow the default flow

and also redirect to some AI landing page on our main website for further reading.

This would be a bigger change... one where we'd need API in getSession to allow a redirect uri to land on.

16 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Explore different login paths · Issue #250086 · microsoft/vscode