Skip to content

feat: Optimize completion range field #135149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ricbet
Copy link

@Ricbet Ricbet commented Oct 15, 2021

improve #71060

The ISuggestDataDto should also be able to compress the range field?

image

{
  startLineNumber: 1,
  startColumn: 2,
  endLineNumber: 3,  -- convert -> [1,2,3,4]
  endColumn: 4,
}

@ghost
Copy link

ghost commented Oct 15, 2021

CLA assistant check
All CLA requirements met.

@jrieken
Copy link
Member

jrieken commented Oct 15, 2021

Thanks so far.

Did you, by any chance, do some measurements about how much this improves receiving large IntelliSense data? Also, a further improvement would be not send the range when an items range is the default value (e.g the range that's computed on the renderer already). Further geek-out would be have the array as [startColumn, endColumn, startLine, (optional) endLine] and leave the endLine out if it's the same as the startLine (which is almost always is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants