Skip to content

Update the copy path commands to run whenever find dialog is not showing, rather than only when editor is not focused. #137217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update the copy path commands to run whenever find dialog is not showing, rather than only when editor is not focused. #137217

wants to merge 5 commits into from

Conversation

a-stewart
Copy link
Contributor

@a-stewart a-stewart commented Nov 15, 2021 •
edited
Loading

Update the copy path and copy relative path commands so that they always run unless the find dialog is visible.
At the moment, they will only run when the editor is not focused.

This PR fixes #137216

@a-stewart a-stewart changed the title Remove the negation from the when clause of the copy path commands Update the copy path commands to run whenever find dialog is not showing, rather than only when editor is not focused. Nov 15, 2021
@a-stewart a-stewart marked this pull request as ready for review November 19, 2021 11:56
@bpasero bpasero mentioned this pull request Nov 24, 2021
Closed
@a-stewart
Copy link
Contributor Author

Hi @rebornix , @bpasero - was just wondering if you might be able to take a look at the PR please.

@rebornix
Copy link
Member

@a-stewart sorry for reaching out late and thank you for the PR. It makes good sense to me to move away from EditorContextKeys.focus but CONTEXT_FIND_WIDGET_VISIBLE.toNegated() feels a bit weird. I wonder if we can do textInputFocus.toNegated() && inputFocus.toNegated(), will give this a try this week.

@rebornix rebornix added this to the May 2022 milestone May 25, 2022
@joyceerhl joyceerhl modified the milestones: May 2022, June 2022 Jun 3, 2022
@connor4312 connor4312 modified the milestones: June 2022, July 2022 Jul 1, 2022
@rebornix rebornix modified the milestones: July 2022, August 2022 Jul 28, 2022
@rebornix rebornix modified the milestones: August 2022, On Deck Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
On Deck
Development

Successfully merging this pull request may close these issues.

Copy Path and Copy Relative Path commands are only available when editor is not focused.
4 participants
@a-stewart @rebornix @connor4312 @joyceerhl