Skip to content

Center actions items (#159517) #159518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jhaemin
Copy link

@jhaemin jhaemin commented Aug 30, 2022

Resolves #159517

Before
Screen Shot 2022-08-30 at 12 14 16 PM

After
Screen Shot 2022-08-30 at 12 14 36 PM

Hovered (composed)
hovered

@weinand weinand assigned daviddossett and miguelsolorio and unassigned weinand Aug 30, 2022
@daviddossett daviddossett self-requested a review August 30, 2022 16:31
Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, I think this aligns better with the panel below so I think this will work (titlebar is separate but will file an issue for that):

CleanShot 2022-08-31 at 10 13 36@2x

I don't think the sidebar needs to align to this since those are different areas.

@@ -437,14 +437,18 @@
.monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions {
cursor: default;
flex: initial;
padding: 0 8px 0 4px;
padding: 0 8px 0 8px;
height: 35px;
}

.monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions .action-item {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the next line below and combine it here like:

Suggested change
.monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions .action-item {
.monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions .action-item:not(:last-child) {

@miguelsolorio miguelsolorio removed their assignment Sep 2, 2022
@jhaemin jhaemin force-pushed the fix-159517 branch 2 times, most recently from a1077bd to 1f4667a Compare June 16, 2023 12:02
@jhaemin
Copy link
Author

jhaemin commented Jun 16, 2023

Alright. It's been quite a while and the layout still needs an adjustment. Please review once again @daviddossett. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor action items are not correctly centered
5 participants