Added rounded corner at the focus line for status bar #164479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddossett
requested changes
Oct 25, 2022
Comment on lines
+537
to
+544
| outline: 0; | ||
| border: 1px solid ${statusBarFocusColor}; | ||
| -webkit-border-bottom-right-radius: 10px; | ||
| -webkit-border-bottom-left-radius: 10px; | ||
| -moz-border-radius-bottomright: 10px; | ||
| -moz-border-radius-bottomleft: 10px; | ||
| border-bottom-right-radius: 10px; | ||
| border-bottom-left-radius: 10px; |
There was a problem hiding this comment.
In many situations we use outline to avoid layout jank when an element doesn't always feature a border. Many themes (like the default dark theme) don't use a border on the status bar unless focused, so the elements might shift around when adding and removing it on focus. Have you verified that moving to a border doesn't cause this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
outlinewithborderandborder-radiusto draw rounded corners for the status barBefore:
After:
