Skip to content

Merge folders within the explorer rather than overwrite #170228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Merge folders within the explorer rather than overwrite #170228

wants to merge 11 commits into from
+72 −7

Conversation

lramos15
Copy link
Member

Fixes #165706

@lramos15 lramos15 self-assigned this Dec 29, 2022
@lramos15 lramos15 requested review from bpasero and jrieken December 29, 2022 16:35
@lramos15 lramos15 added this to the January 2023 milestone Dec 29, 2022
bpasero
bpasero requested changes Dec 29, 2022
View reviewed changes
@lramos15 lramos15 modified the milestones: January 2023, February 2023 Jan 23, 2023
@lramos15 lramos15 added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Jan 25, 2023
@lramos15 lramos15 requested a review from bpasero February 14, 2023 17:15
@lramos15
Copy link
Member Author

@bpasero I think this is ready for a re-review. Let me know if you think we should take this in for this iteration or wait until the next 👍

@bpasero
Copy link
Member

bpasero commented Feb 16, 2023

Well, there is commented out lines and console.log statements in the change, so I had assumed this is still in draft mode.

@lramos15
Copy link
Member Author

Well, there is commented out lines and console.log statements in the change, so I had assumed this is still in draft mode.

Oops. That was my bad for not checking those were gone, this has been fixed now. Thanks for pointing them out.

bpasero
bpasero requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be inconsistent capital casing in the buttons:

image

Also, I only was able to get this dialog when doing a DND operation inside the explorer, but why does this not work when I drop a folder from macOS finder into the explorer?

@lramos15 lramos15 modified the milestones: February 2023, March 2023 Feb 17, 2023
@lramos15 lramos15 modified the milestones: March 2023, April 2023 Mar 20, 2023
@lramos15 lramos15 removed this from the April 2023 milestone Apr 25, 2023
@lramos15 lramos15 added this to the On Deck milestone Apr 25, 2023
@vivodi
Copy link

vivodi commented Dec 29, 2024

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero requested changes

@jrieken jrieken Awaiting requested review from jrieken

Requested changes must be addressed to merge this pull request.

Assignees

@lramos15 lramos15

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Milestone
On Deck
Development

Successfully merging this pull request may close these issues.

Allow to merge folders when moved to a location where folder already exists
3 participants
@lramos15 @bpasero @vivodi