Add persistent visual labels to find input #171777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
isidorn
added
the
accessibility
|
|
jjaeggli:persistent-labels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change
This change implements persistent visual labels in accordance with WCAG 2.1 success criteria 3.3.2, notably addresses the issue that placeholder text does not provide sufficient labels for input fields as described here w3c/wcag#864 and in other sources. This PR serves as an example of a potential change which could address the issue. It may need further review or discussion with UX. Otherwise, if the change sufficiently addresses the issue, it may be merged.
Similar issues have even been addressed in other Microsoft projects, ex.
microsoft/pxt-microbit#2332
Issue:
#167870
How to test:
Screenshots:
Electron
Web