fix #174534 #175813
fix #174534 #175813
Conversation
Signed-off-by: Svetozar Mateev <svetozar.mateev@tick42.com>
|
|
||
| return false; | ||
| return !this._cursorPositions[0]?.equals(newPositions[0]); |
There was a problem hiding this comment.
If think you should rather check if the list of previous cursors equals the list of new cursors.
There was a problem hiding this comment.
My idea was to keep as much of the original behavior as possible where changes are not required. If I check the whole list that would mean the method will return true when some of the none primary cursors are changed. From what I saw in the code this is not necessary, but if my assumption is not correct I will be happy to change it.
| ): IndentGuide[][] { | ||
| const bracketGuides = this._bracketPairGuideOptions.bracketPairs !== false | ||
| ? this._context.viewModel.getBracketGuidesInRangeByLine( | ||
| visibleStartLineNumber, | ||
| visibleEndLineNumber, | ||
| activeCursorPosition, | ||
| activeCursorPositions[0], |
There was a problem hiding this comment.
This is problematic. I think here you would have to pass in all the active positions.
@microsoft-github-policy-service agree |
…tion too and changed the comparison logic Signed-off-by: Svetozar Mateev <svetozar.mateev@tick42.com>
Fixed issue #174534 by setting the active state of the indent guides based on all of the cursors. Can be tested by creating multiple cursors in a file with indent guides (editor.guides.highlightActiveBracketPair must be true).