-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Add token colors for dark plus experimental #177231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@PatricPippi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@PatricPippi could you share some examples of what the changes look like before/after? Screenshots are always helpful here 👍 |
Sure, here's the difference: After ( #b4b4b4 ), is a subtle difference, but, note that keywords like operators and address are more readable. I chose this color for the keywords so as not to deviate from the color palette, but if you have a better suggestion, it would be welcome. |
@microsoft-github-policy-service agree |
@daviddossett any response about that ? |
Will take a look next week. Super busy on a time sensitive project this week. Thanks for your patience! |
Thanks for your attention bro. |
Add keyword color for some operators, this helps with the contrast for reading.