Close webview when extension host restart #225979
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BABA983
commented
Aug 19, 2024
| public override dispose(): void { | ||
| for (const webview of this._webviewInputs) { | ||
| if (typeof webview.group === 'number' && webview.webview.options.autoCloseWhenDispose) { | ||
| this._editorService.closeEditor({ editor: webview, groupId: webview.group }); |
There was a problem hiding this comment.
webview.dispose() will do the same. But maybe we can do it explicitly here to make it more readable.
BABA983
force-pushed
the
feature/close-webview-when-extension-host-restart
branch
from
0b0d70b to
9bd97e7
Compare
|
@mjbvz Would you might take some time to look at this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #70656
Not all webviews require an extension to live in the background.
Instead of all the panels being closed when disposed, introduce a new option in
WebviewPanelOptionsthat can close webview editor when the extension host restart.