Skip to content

Fix for pinch gesture scrolling while zoom on MacOS trackpad #239432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kalebers
Copy link

@kalebers kalebers commented Feb 2, 2025

Fix for issue #204654 where on MacOS while making the pinch gesture makes an unwanted scroll.

This fix allows to detect pinch movement and prevent the scroll while making the gesture.

Please give me feedback for this fix, would appreciate tips on how to improve!

@kalebers kalebers changed the title Fix for pinch scroll while zooming on MacOS trackpad Fix for pinch gesture scrolling while zoom on MacOS trackpad Feb 3, 2025
@lramos15 lramos15 assigned alexdima and unassigned lramos15 Feb 3, 2025
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR would make it on all platforms that pressing the ctrl key and scrolling is interpreted as a pinch gesture. I don't think this would be a good change.

@kalebers
Copy link
Author

@alexdima do you have a different idea? I can modify this in order to improve.

@alexdima
Copy link
Member

@kalebers Maybe we can guard it additionally with platform.isMacintosh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants