Add 'hidden' option to titleScrollbarSizing #244551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
|
@bpasero is this something you're familiar with (looking at some blames)? |
benibenj
requested changes
May 5, 2025
| @@ -264,11 +265,12 @@ export class MultiEditorTabsControl extends EditorTabsControl { | |||
| } | |||
|
|
|||
| private getTabsScrollbarSizing(): number { | |||
| if (this.groupsView.partOptions.titleScrollbarSizing !== 'large') { | |||
| return MultiEditorTabsControl.SCROLLBAR_SIZES.default; | |||
| if (this.groupsView.partOptions.titleScrollbarSizing === 'hidden') { | |||
There was a problem hiding this comment.
Hidden should not be part of the sizes, but part of the visibility. horizontal should be set to ScrollbarVisibility.Hidden instead of ScrollbarVisibility.Auto here:
There was a problem hiding this comment.
That was my first implementation, but in order to not complicate the code I went with this approach, since eventually ScrollbarVisibility.Hidden is converted to 0 size here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issues #111817, #157045, #185625.
The title scrollbar can be disabled by setting
titleScrollbarSizingparameter tohidden.The default remains unchanged.
Tested on Ubuntu 24.04 machine.