-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Update copyFiles.ts #250773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update copyFiles.ts #250773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall — adding isoTime is a nice touch for more readable timestamps when copying files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to include any code changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['isoTime', new Date().toISOString()]
Adds a variable 'isoTime' in the resolveCopyDestinationSetting function which lets users include ${isoTime} in the destination path template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This also needs to be documented in for the settings. Check the markdown-language-features
settings json
I opened a follow up PR to document the added isotime variable in the setting description |
Please put all the related changes into a single PR. That helps review and tracking work on the feature |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjbvz unit tests failing, might need to report the flake to the test owner?
add isoTime to markdown extension copy file destination options.
I guess many people need that (e.g., me)