Skip to content

Update copyFiles.ts #250773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update copyFiles.ts #250773

wants to merge 4 commits into from

Conversation

ghLcd9dG
Copy link

@ghLcd9dG ghLcd9dG commented Jun 5, 2025

add isoTime to markdown extension copy file destination options.
I guess many people need that (e.g., me)

Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall — adding isoTime is a nice touch for more readable timestamps when copying files.

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to include any code changes

Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['isoTime', new Date().toISOString()]
Adds a variable 'isoTime' in the resolveCopyDestinationSetting function which lets users include ${isoTime} in the destination path template.

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This also needs to be documented in for the settings. Check the markdown-language-features settings json

@DhruvTheDev1
Copy link

I opened a follow up PR to document the added isotime variable in the setting description
Update package.nls.json #251706

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 17, 2025

Please put all the related changes into a single PR. That helps review and tracking work on the feature

@ghLcd9dG
Copy link
Author

@ghLcd9dG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@mjbvz mjbvz enabled auto-merge June 20, 2025 16:08
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 20, 2025
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz unit tests failing, might need to report the flake to the test owner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants