[WIP] Notebook Variables aria label doesn't update

[Copilot]

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

Not updating for me.

can repro with jupyter and python extensions and setting "notebook.variablesView": true,

1. set a variable in a notebook, set a variable in a native python repl (Python: start native python REPL)
2. with the debug sidebar open, the "notebook variables" tree view will change to "REPL variables" depending on which editor is focused
3. Narration always reads "Notebook Variables"

treeview.title.mp4

Originally posted by @amunger in #239375

Fixes #242545.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[amunger]

@copilot can you try again?

[Copilot]

@copilot can you try again?

I've fixed the issue by making the aria label dynamic. The NotebookVariableAccessibilityProvider now updates its aria label when switching between notebook and REPL variables, ensuring screen readers announce the correct context. The fix is in commit bb3f1f8.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• electronjs.org
  • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[amunger]

@copilot This getter is only called once, so we need to use an IObservable, then the update method will just update the value of that observable.
The observable interface is in src\vs\workbench\contrib\notebook\browser\contrib\notebookVariables\notebookVariablesTree.ts

[Copilot]

I've updated the implementation to use an observable pattern. The NotebookVariableAccessibilityProvider now uses observableValue for the widget aria label, and I've set up an autorun in the view to watch the observable and update the tree's aria label when it changes. The fix is in commit b54a699.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• electronjs.org
  • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list